[mlir][python] source line info #149166
Closed
[mlir][python] source line info #149166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/jax-locs-traceback
branch
from
bec65c3 to
b502ab6
Compare
makslevental
force-pushed
the
makslevental/jax-locs-traceback
branch
2 times, most recently
from
ebf792d to
1d1b3b9
Compare
You can test this locally with the following command:git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- mlir/lib/Bindings/Python/Traceback.cpp mlir/lib/Bindings/Python/Traceback.h mlir/lib/Bindings/Python/IRCore.cpp mlir/lib/Bindings/Python/IRModule.h mlir/lib/Bindings/Python/MainModule.cppView the diff from clang-format here.diff --git a/mlir/lib/Bindings/Python/IRModule.h b/mlir/lib/Bindings/Python/IRModule.h
index e21d8660e..87e1a0b12 100644
--- a/mlir/lib/Bindings/Python/IRModule.h
+++ b/mlir/lib/Bindings/Python/IRModule.h
@@ -722,8 +722,7 @@ public:
llvm::ArrayRef<MlirValue> operands,
std::optional<nanobind::dict> attributes,
std::optional<std::vector<PyBlock *>> successors, int regions,
- PyLocation location, const nanobind::object &ip,
- bool inferType);
+ PyLocation location, const nanobind::object &ip, bool inferType);
/// Creates an OpView suitable for this operation.
nanobind::object createOpView();
|
makslevental
force-pushed
the
makslevental/jax-locs-traceback
branch
4 times, most recently
from
1723eb9 to
46adb54
Compare
makslevental
force-pushed
the
makslevental/jax-locs-traceback
branch
6 times, most recently
from
7a5a911 to
f10e124
Compare
makslevental
force-pushed
the
makslevental/jax-locs-traceback
branch
from
f10e124 to
f60824e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.